Warning not usual

rgb

Summary

Warning doesn't give any information (number line of begin potential problems)

Objo Studio Version

Operating System

Select the operating system(s) affected as tags for this post.

Steps To Reproduce

Expected Result

Actual Result

Screenshots, Logs, Or Sample Project

bgrommes

Since this is a warning about the overall structure of the entire method (cyclomatic complexity) I don't see how it would provide a line number. However, it might be nice if (1) it indicates one or more aspects of the measurement it's using and (2) if that threshold for this warning were configurable.

I sometimes find breaking methods down in size just to avoid being dinged by this sort of warning is just moving complexity around, not necessarily in ways that reduce cognitive burden. So I like to be able to quiet the constant nattering in a couple of my .NET solutions or I would be multiplying abstractions just to avoid the warning (eg moving things into truth tables so I don't have lengthy case or if / else statements). Same goes for "it's remotely possible that this value could be null at runtime" kinds of warnings (if Objo were supporting nullables). Sometimes I want to live close to the edge in the interest of performance or other considerations. I should be able to.

rgb

bgrommes

Hi, you are right, it's not a bug but if Objo can be more explicit can help 😉

Garry

Thanks both. You’re right: this isn’t a compiler bug as such. The warning is about the overall control-flow complexity of the method, so there isn’t always one single “bad” line.

That said, the current UX was too vague, especially when Studio reports it against a hidden control event declaration like Window1 ListBox1.Opening declaration.

I’ve changed this for the next release (https://feedback.objo.dev/bug/433).

The warning will now include the score and threshold, plus the largest contributor, for example a long ElseIf chain or large Select Case. Studio will also point/navigate to that visible contributor line inside the handler instead of just showing the declaration.

The method complexity warning can be switched off in Settings > Analyser > Complexity warnings > Method complexity. I haven’t made the numeric threshold configurable yet, but I agree that may be useful if people want this warning enabled but tuned differently.