Database class

PaulS

Problem

We have current 3 database types, SQLiteDatase, PostgreSQLDatabase and MySQLDatabase.
Many of the methods are the same for each database.
The problem I have that I need to check all the time which database is used.

Select Case DbType
Case 0 # SQLiteDatabase
  rs = DbS.SelectSQL(TheSQLQuery.Trim())
Case 1 # PostgreSQLDatabase
  rs = DbP.SelectSQL(TheSQLQuery.Trim())
Case 2 # MySQLDatabase
  rs = DbM.SelectSQL(TheSQLQuery.Trim())
End Select

If I could assign DbS, DbP or DbM to the class Database (property mDb) when connecting to the database it is only there where it is needed to check what database is used.

Select Case DbType
Case 0 # SQLiteDatabase
  mDb = DbS
Case 1 # PostgreSQLDatabase
  mDb = DbP
Case 2 # MySQLDatabase
  mDb = DbM
End Select

Above would become very simple

rs = mDb.SelectSQL(TheSQLQuery.Trim)

Proposed Solution

Add Database as class for subclasses SQLiteDatabase, PostgreSQLDatabase and MySQLDatabase

Example Workflow

Alternatives Considered

Who Would This Help?

All that use multiple databases

Garry

Thanks Paul. This is a good suggestion and it has been implemented for the next release: https://feedback.objo.dev/feature/396

SQLiteDatabase, MySQLDatabase, and PostgreSQLDatabase now implement a shared Database interface, so common code can keep one property:

Private Property Db As Database

Db = New SQLiteDatabase(file)
Var rs As RecordSet = Db.SelectSQL(sql.Trim())

Provider-specific construction still happens through the concrete classes, and provider-specific options such as SQLite’s WriteAheadLogging remain on those concrete classes. This does not try to hide SQL dialect differences, but it removes the repeated type checks for the shared database operations.

The bundled database examples and documentation have been updated as well.