RowTag vs ItemTag

bryhutson

I notice that ListBox and PopupMenu both use RowTag methods to retrieve tag data, but ComboBox uses an ItemTag method for the same purpose.

Would it be more consistent to use RowTag for all three controls since all have rows associated with them?

Garry

Good catch and it actually runs a little deeper than the tag methods. ComboBox names its whole list API with Item vocabulary (AddItem, ItemAt, ItemCount, SelectedIndex, ItemTag…), while ListBox and PopupMenu use Row vocabulary throughout. You're right that it's inconsistent, and ComboBox is the odd one out.

I'm going to unify ComboBox on the Row naming, on both desktop and web:

New	Replaces
`RowCount`	`ItemCount`
`AddRow` / `AddRows`	`AddItem` / `AddItems`
`AddRowAt`	`InsertItem`
`RemoveRow` / `RemoveAllRows`	`RemoveItem` / `RemoveAll`
`RowTextAt`	`ItemAt`
`SelectedRowIndex` / `SelectedRowText`	`SelectedIndex` / `SelectedItem`
`RowTag` / `SetRowTag` / `IndexOfRowTag`	`ItemTag` / `SetItemTag` / `IndexOfItemTag`

This will be non-breaking. The existing Item methods continue to work as deprecated compatibility aliases, so existing projects compile unchanged - you'll just see a deprecation warning naming the replacement, and the old names appear struck through in autocomplete so new code is steered towards the Row names. Text, Placeholder, AutoComplete, Sorted, ReadOnly, IndexOf, Sort and the Changed event keep their current names.

Thanks for raising it. I'll be implementing this soon and it will ship in a future release. You can follow it at https://feedback.objo.dev/feature/1580

Garry

This has been added to the next release.